Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bld): await archiver.finalize #1333

Merged
merged 3 commits into from
Jan 1, 2025
Merged

fix(bld): await archiver.finalize #1333

merged 3 commits into from
Jan 1, 2025

Conversation

ayushmanchhabra
Copy link
Collaborator

Fixes: #1328

Copy link
Contributor

github-actions bot commented Jan 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 36.89% 721 / 1954
🔵 Statements 36.89% 721 / 1954
🔵 Functions 41.93% 13 / 31
🔵 Branches 59.52% 50 / 84
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/bld.js 31.04% 100% 0% 31.04% 111-200, 203-248, 251-293, 296-354, 357-366, 369-391
Generated in workflow #1049 for commit 98281e9 by the Vitest Coverage Report Action

@ayushmanchhabra ayushmanchhabra merged commit 580668f into main Jan 1, 2025
5 of 6 checks passed
@ayushmanchhabra ayushmanchhabra deleted the dev-1328 branch January 1, 2025 17:11
ayushmanchhabra pushed a commit that referenced this pull request Jan 1, 2025
🤖 I have created a release *beep* *boop*
---


##
[4.13.8](v4.13.7...v4.13.8)
(2025-01-01)


### Bug Fixes

* **bld:** await archiver.finalize
([#1333](#1333))
([580668f](580668f)),
closes [#1328](#1328)


### Chores

* **deps:** bump the npm group across 1 directory with 11 updates
([#1332](#1332))
([b9b96ff](b9b96ff))
* **docs:** clarify CJS usage
([d673459](d673459)),
closes [#1331](#1331)
* **docs:** clarify non-usage of srcDir in CLi interface
([1b61bd1](1b61bd1)),
closes [#1330](#1330)
* **docs:** fix CJS import usage example
([5f323df](5f323df)),
closes [#1331](#1331)
* **test:** download latest NW.js version for Linux demo app
([8c09908](8c09908)),
closes [#1324](#1324)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zip doesn't work, app compression?
1 participant